Update tests and docs for waitForCondition#241
Merged
zhongkechen merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
zhongkechen
approved these changes
Mar 19, 2026
| ? WaitForConditionResult.stopPolling(latest) | ||
| : WaitForConditionResult.continuePolling(latest); | ||
| }, | ||
| "PENDING"); |
Contributor
There was a problem hiding this comment.
I'm not sure if initialState is still useful to users. Looks like users can always directly pass their initial state into the lambda without a parameter.
|
|
||
| private WaitStrategies() { | ||
| // Utility class - prevent instantiation | ||
| } |
Contributor
There was a problem hiding this comment.
why do we remove this?
| ├── CallbackException - General callback exception | ||
| │ ├── CallbackFailedException - External system sent an error response to the callback. Handle the error or propagate failure | ||
| │ └── CallbackTimeoutException - Callback exceeded its timeout duration. Handle the error or propagate the failure | ||
| ├── WaitForConditionException - waitForCondition exceeded max polling attempts or failed. Catch to implement fallback logic. |
Contributor
There was a problem hiding this comment.
with a subclass WaitForConditionFailedException?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#90
Description
Added new unit tests to cover previously uncovered branches in
waitForConditionOperation(used the new coverage report to find uncovered branches).Updated the
testCheckFunctionErrorwaitForConditionintegration test, to verify that an exception from the user provided check function is propagated properly.Added new unit test for when deserializing a
waitForConditioncheckpoint fails, which verifies aSerDesExceptionis thrown and propagated.Updated
waitForConditionExampleto demonstrate a more realistic scenario.WaitForConditionResult(and it's test) was moved to themodel/folder.Simplified comments / removed unnecessary comments in general.
Updated existing docs / added new doc for
waitForConditionDemo/Screenshots
N/A
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Yes
Integration Tests
Have integration tests been written for these changes?
Yes
Examples
Has a new example been added for the change? (if applicable)
Yes